[refactor](schema_hash) remove schema_hash since every tablet id in be is unique#8574
Conversation
|
Great. |
|
@yangzhg now, for upgrade compatibility , it is not the time to modify meta_tool, and url of show tablet command, |
I think it's understandable to bring some compatibility problems when a big version is released, and there are not many users of meta_tool and url, so it's better to modify them together |
I find that I cannot refactor all schema hash code because the schema_hash dir now already in data path, |
|
Schema hash is currently widely used in various modules of BE and is strongly related to the data itself. It is recommended to add the following content to the PR:
|
This PR mainly modify following modules:
|
yiguolei
left a comment
There was a problem hiding this comment.
LGTM
I've pull the pr to local and build successfully.
|
PR approved by anyone and no changes requested. |
| @@ -1552,10 +1549,9 @@ void TaskWorkerPool::_move_dir_thread_callback() { | |||
| Status TaskWorkerPool::_move_dir(const TTabletId tablet_id, const TSchemaHash schema_hash, | |||
There was a problem hiding this comment.
remove schema_hash in parameter
Proposed changes
Issue Number: close #xxx
Problem Summary:
1.Now, schema_hash is part of the data_dir path, but tablet id is unique, so we can read tablet info only by tablet_id,
so this PR only modify get_tablet and drop_tablet function in be, not refactor write schema_hash logic in be.
module in be who use get_tablet and drop_tablet function will be affected.
2. For users, this PR change two httpAction in be, one is metaAction, and the other is CompactionAction. so I also modify the doc and fe code.
3.The main Purpose of this PR is to simplify managing tablet, whether to remove all schema_hash still need more discussion, because we need to consider compatibility and correctness after refactor.
Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...