[fix](storage) Fix core bug of convert to predicate column#8833
Merged
morningman merged 1 commit intoapache:masterfrom Apr 7, 2022
Merged
[fix](storage) Fix core bug of convert to predicate column#8833morningman merged 1 commit intoapache:masterfrom
morningman merged 1 commit intoapache:masterfrom
Conversation
morningman
added
kind/fix
Contributor
|
If this core dump has a stack info, you can open an issue and post stack in it. Then releated to this pr. |
Member
Author
ok, i created an issue: #8835 |
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
wangbo
added
area/storage
morningman
pushed a commit
that referenced
this pull request
Apr 8, 2022
recurrent: When `enable_low_cardinality_optimize = true`, for the TPCH dataset, using the following SQL query will Core ```sql select count(*) from lineitem where l_comment = 'ously even exc'; ``` This SQL will trigger the execution of `ColumnDictionary::convert_to_predicate_column_if_dictionary`, and `res->reserve(_codes.size())` is problematic because the current `_codes.size()` is smaller than its reserve value, so inserting a value into `PredicateColumn` will Core.
morningman
added
dev/merged-1.0.1-deprecated
weizhengte
pushed a commit
to weizhengte/incubator-doris
that referenced
this pull request
Apr 22, 2022
recurrent: When `enable_low_cardinality_optimize = true`, for the TPCH dataset, using the following SQL query will Core ```sql select count(*) from lineitem where l_comment = 'ously even exc'; ``` This SQL will trigger the execution of `ColumnDictionary::convert_to_predicate_column_if_dictionary`, and `res->reserve(_codes.size())` is problematic because the current `_codes.size()` is smaller than its reserve value, so inserting a value into `PredicateColumn` will Core.
zhengshiJ
pushed a commit
to zhengshiJ/incubator-doris
that referenced
this pull request
Apr 27, 2022
recurrent: When `enable_low_cardinality_optimize = true`, for the TPCH dataset, using the following SQL query will Core ```sql select count(*) from lineitem where l_comment = 'ously even exc'; ``` This SQL will trigger the execution of `ColumnDictionary::convert_to_predicate_column_if_dictionary`, and `res->reserve(_codes.size())` is problematic because the current `_codes.size()` is smaller than its reserve value, so inserting a value into `PredicateColumn` will Core.
|
1.1.3 rc2 version has this core bug |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #8315 #8835
Fix core bug of convert to predicate column
Problem Summary:
recurrent:
When
enable_low_cardinality_optimize = true, for the TPCH dataset, using the following SQL query will CoreThis SQL will trigger the execution of
ColumnDictionary::convert_to_predicate_column_if_dictionary, andres->reserve(_codes.size())is problematic because the current_codes.size()is smaller than its reserve value, so inserting a value intoPredicateColumnwill Core.Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...