Skip to content

[enhancement] (odbc) support more ODBC Connection Parameters for odbc external table#9198

Merged
morningman merged 1 commit intoapache:masterfrom
yangzhg:odbc_more
May 5, 2022
Merged

[enhancement] (odbc) support more ODBC Connection Parameters for odbc external table#9198
morningman merged 1 commit intoapache:masterfrom
yangzhg:odbc_more

Conversation

@yangzhg
Copy link
Member

@yangzhg yangzhg commented Apr 24, 2022

Proposed changes

user can add more supported ODBC Connection Parameters to resoure PROPERTIES or exteranl table PROPERTIES

Problem Summary:

Describe the overview of changes.

Checklist(Required)

  1. Does it affect the original behavior: (Yes/No/I Don't know)
  2. Has unit tests been added: (Yes/No/No Need)
  3. Has document been added or modified: (Yes/No/No Need)
  4. Does it need to update dependencies: (Yes/No)
  5. Are there any changes that cannot be rolled back: (Yes/No)

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@github-actions github-actions bot added the kind/docs Categorizes issue or PR as related to documentation. label Apr 24, 2022
@yangzhg yangzhg force-pushed the odbc_more branch 2 times, most recently from c987282 to e828cd6 Compare April 26, 2022 10:58
driver = serializeMap.get(ODBC_DRIVER);
odbcTableTypeName = serializeMap.get(ODBC_TYPE);
charset = serializeMap.get(ODBC_CHARSET);
extraParam = serializeMap.get(ODBC_EXTRA_PARAM);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update he help doc of create table to add example for these 2 params.

@morningman morningman added kind/fix Categorizes issue or PR as related to a bug. area/odbc labels May 5, 2022
… external table

user can add more supported ODBC Connection Parameters to resoure PROPERTIES or exteranl table PROPERTIES
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label May 5, 2022
@github-actions
Copy link
Contributor

github-actions bot commented May 5, 2022

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented May 5, 2022

PR approved by anyone and no changes requested.

@morningman morningman merged commit 6d1c300 into apache:master May 5, 2022
starocean999 pushed a commit to starocean999/incubator-doris that referenced this pull request May 19, 2022
…external table (apache#9198)

user can add more supported ODBC Connection Parameters to resource PROPERTIES or external table PROPERTIES
englefly pushed a commit to englefly/incubator-doris that referenced this pull request May 23, 2022
…external table (apache#9198)

user can add more supported ODBC Connection Parameters to resource PROPERTIES or external table PROPERTIES
yiguolei pushed a commit that referenced this pull request Aug 19, 2022
…external table (#9198)

user can add more supported ODBC Connection Parameters to resource PROPERTIES or external table PROPERTIES
Henry2SS pushed a commit to Henry2SS/incubator-doris that referenced this pull request Sep 14, 2022
…external table (apache#9198)

user can add more supported ODBC Connection Parameters to resource PROPERTIES or external table PROPERTIES
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. area/odbc dev/merge-1.1.2 kind/docs Categorizes issue or PR as related to documentation. kind/fix Categorizes issue or PR as related to a bug. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants