[Feature] [Backend] support build be with c++20#9313
Closed
BiteTheDDDDt wants to merge 7 commits intoapache:masterfrom
Closed
[Feature] [Backend] support build be with c++20#9313BiteTheDDDDt wants to merge 7 commits intoapache:masterfrom
BiteTheDDDDt wants to merge 7 commits intoapache:masterfrom
Conversation
Contributor
|
Wow |
Contributor
|
you need to update dist/LICENSES-dist.txt |
yiguolei
reviewed
May 7, 2022
| -DCMAKE_MAKE_PROGRAM="${MAKE_PROGRAM}" \ | ||
| -DCMAKE_EXPORT_COMPILE_COMMANDS=ON \ | ||
| -DCMAKE_BUILD_TYPE=${CMAKE_BUILD_TYPE} \ | ||
| -DCMAKE_PREFIX_PATH=${DORIS_THIRDPARTY}/installed \ |
Contributor
There was a problem hiding this comment.
Why add this config? Doris will import every lib instead of set the prefix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #9312
Problem Summary:
Describe the overview of changes.
Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...