DRILL-6007: Use default refresh timeout (10 seconds) if graceful shut…#1062
Closed
arina-ielchiieva wants to merge 1 commit intoapache:masterfrom
Closed
DRILL-6007: Use default refresh timeout (10 seconds) if graceful shut…#1062arina-ielchiieva wants to merge 1 commit intoapache:masterfrom
arina-ielchiieva wants to merge 1 commit intoapache:masterfrom
Conversation
…down timeout is set to 0.
arina-ielchiieva
force-pushed
the
DRILL-6007
branch
2 times, most recently
from
a8b6ae6 to
a4e1b8c
Compare
parthchandra
approved these changes
Dec 8, 2017
Contributor
parthchandra
left a comment
parthchandra
left a comment
There was a problem hiding this comment.
+1 (Fixes the issue of continuously refreshing).
Code could do with some improvements. (Can be done later)
| <script charset="utf-8"> | ||
| var refreshTime = 2000; | ||
| var refreshTime = 10000; | ||
| var refresh = getRefreshTime(); |
Contributor
There was a problem hiding this comment.
This is confusing isn't it? The function does not return a value and yet the return value () is stored in a variable that is not used.
Luckily it's not used anywhere.
Member
Author
|
Agree, I have created Jira for js part improvement where I have indicated some other things that should be improved (https://issues.apache.org/jira/browse/DRILL-6022). |
ilooner
pushed a commit
to ilooner/drill
that referenced
this pull request
Jan 30, 2018
…down timeout is set to 0. closes apache#1062
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…down timeout is set to 0.