DRILL-6130: Fix NPE during physical plan submission for various storage plugins#1108
Closed
arina-ielchiieva wants to merge 1 commit into
Closed
DRILL-6130: Fix NPE during physical plan submission for various storage plugins#1108arina-ielchiieva wants to merge 1 commit into
arina-ielchiieva wants to merge 1 commit into
Conversation
Member
arina-ielchiieva
commented
Feb 2, 2018
arina-ielchiieva
commented
- Fixed ser / de issues for Hive, Kafka, Hbase plugins.
- Added physical plan submission unit test for all storage plugins in contrib module.
- Refactoring.
Member
Author
|
@vdiravka please review. |
vdiravka
reviewed
Feb 7, 2018
Member
vdiravka
left a comment
vdiravka
left a comment
There was a problem hiding this comment.
Two minor comments.
Except them +1, LGTM
| @Override | ||
| public int getOperatorType() { | ||
| return CoreOperatorType.HBASE_SUB_SCAN_VALUE; | ||
| return -1; |
Member
There was a problem hiding this comment.
Can we add KUDU_SUB_SCAN_VALUE to CoreOperatorType and use here?
| @@ -175,9 +175,8 @@ public void testBasicQueryWithNonExistentTableName() throws Exception { | |||
|
|
|||
| @Test | |||
| public void testPhysicalPlanExecutionBasedOnQuery() throws Exception { | |||
Member
There was a problem hiding this comment.
testPhysicalPlanExecutionBasedOnQuery -> testPhysicalPlanSubmission
…ge plugins 1. Fixed ser / de issues for Hive, Kafka, Hbase plugins. 2. Added physical plan submission unit test for all storage plugins in contrib module. 3. Refactoring.
arina-ielchiieva
force-pushed
the
DRILL-6130
branch
from
aabd11c to
0b9e8c7
Compare
Member
Author
|
@vdiravka thanks for the code review. Addressed two comments. |
vdiravka
approved these changes
Feb 15, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.