DRILL-6273: Removed dependency licensed under Category X #1195
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vrozov
reviewed
Mar 30, 2018
| @@ -0,0 +1,28 @@ | |||
| /** | |||
Member
There was a problem hiding this comment.
Please do not use doc comment for the license.
| * limitations under the License. | ||
| */ | ||
| package bsh; | ||
| /** |
Member
There was a problem hiding this comment.
will be better to have this comment in package-info.
| <groupId>commons-logging</groupId> | ||
| </exclusion> | ||
| <exclusion> | ||
| <artifactId>bsh</artifactId> |
Member
There was a problem hiding this comment.
add bsh:org.beanshell to the prohibited dependencies.
vrozov
reviewed
Apr 3, 2018
| * Apache License, So beanshell is excluded and EvalError class is added to handle the dependency. | ||
| */ | ||
|
|
||
| package bsh; No newline at end of file |
Member
There was a problem hiding this comment.
Please add LF and squash commits.
Member
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@vrozov Please review