DRILL-6785: DataClient is using RootAllocator in the bootstrap instea… #1502
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@sohami the change seems obvious but could you please highlight what incorrect usage causes and how issue was found? |
Contributor
Author
|
@arina-ielchiieva - There was no issues which was caused/found because of this. I happen to notice it while browsing code so made the change for correctness. |
Member
|
Sounds good, +1 |
Contributor
|
@sohami what is teh QA impact for this? |
arina-ielchiieva
approved these changes
Oct 19, 2018
mattpollack
pushed a commit
to mattpollack/drill
that referenced
this pull request
Feb 25, 2019
…d of dataPool closes apache#1502
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…d of dataPool