DRILL-6861: Hash-Join should not exit after an empty probe-side spilled partition#1546
Merged
Ben-Zvi merged 1 commit intoapache:masterfrom Nov 20, 2018
Merged
DRILL-6861: Hash-Join should not exit after an empty probe-side spilled partition#1546Ben-Zvi merged 1 commit intoapache:masterfrom
Ben-Zvi merged 1 commit intoapache:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(The DIFF below is excessive due to indentation; but only two "lines" where actually changed).
The original code below handles the spilled partitions by getting the next one (as build+probe "incoming"), and then recursively calling innerNext(). Each recursive call would end by (recursively) processing the next spilled partition.
The DRILL-6755 change (line 556) caused an early exit when the probe side was empty. Thus in special cases when a probe-side of a spilled partition was empty, this change would terminate the recursive chain early, thus not processing the remaining partitions.
The fix: When an empty probe-side spilled partition is seen - skip and process the next partition. A new check was added (line 624), and the code was altered into a "while" loop (line 618) to allow skipping.