DRILL-6959: Fix loss of precision when casting time and timestamp literals in filter condition #1607
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@KazydubB could you please review? |
Member
|
@vvysotskyi could you change commit message to reflect actual changes, please? |
…erals in filter condition
vvysotskyi
force-pushed
the
DRILL-6959
branch
from
4e15b41 to
872fb1a
Compare
vvysotskyi
changed the title
Member
Author
|
@KazydubB, done. |
lushuifeng
pushed a commit
to lushuifeng/drill
that referenced
this pull request
Jun 21, 2019
…erals in filter condition closes apache#1607
xiangt920
pushed a commit
to xiangt920/drill
that referenced
this pull request
Dec 26, 2019
…erals in filter condition closes apache#1607
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VARCHAR,TIMEandTIMESTAMPtypes to avoid the literal trimming during the cast removing.For problem description please see DRILL-6959.