DRILL-6533: Allow using literal values in functions which expect FieldReader instead of ValueHolder#1617
Closed
vvysotskyi wants to merge 1 commit intoapache:masterfrom
Closed
DRILL-6533: Allow using literal values in functions which expect FieldReader instead of ValueHolder#1617vvysotskyi wants to merge 1 commit intoapache:masterfrom
vvysotskyi wants to merge 1 commit intoapache:masterfrom
Conversation
| for (int i = 0; i < holderExpr.args.size(); i++) { | ||
| args[i] = holderExpr.args.get(i).accept(this, inIndex); | ||
| ValueHolder valueHolder = holderExpr.args.get(i).accept(this, inIndex); | ||
| args[i] = valueHolder; |
Member
There was a problem hiding this comment.
Maybe it is better to define argument in the variable and then in the end set it args?
…dReader instead of ValueHolder
vvysotskyi
force-pushed
the
DRILL-6533
branch
from
137bb74 to
c93b7bb
Compare
Member
|
+1 |
lushuifeng
pushed a commit
to lushuifeng/drill
that referenced
this pull request
Jun 21, 2019
…dReader instead of ValueHolder closes apache#1617
xiangt920
pushed a commit
to xiangt920/drill
that referenced
this pull request
Dec 26, 2019
…dReader instead of ValueHolder closes apache#1617
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For details please see DRILL-6533.