DRILL-7035: Drill C++ Client crashes on multiple SaslAuthenticatorImpl destruction due to communication error#1660
Closed
debraj92 wants to merge 1 commit intoapache:masterfrom
Closed
DRILL-7035: Drill C++ Client crashes on multiple SaslAuthenticatorImpl destruction due to communication error#1660debraj92 wants to merge 1 commit intoapache:masterfrom
debraj92 wants to merge 1 commit intoapache:masterfrom
Conversation
…l destruction due to communication error
sohami
approved these changes
Feb 27, 2019
Contributor
sohami
left a comment
sohami
left a comment
There was a problem hiding this comment.
+1. Thanks for fixing this
lushuifeng
pushed a commit
to lushuifeng/drill
that referenced
this pull request
Jun 21, 2019
…l destruction due to communication error closes apache#1660
xiangt920
pushed a commit
to xiangt920/drill
that referenced
this pull request
Dec 26, 2019
…l destruction due to communication error closes apache#1660
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fix for this is essentially ensuring that the null check and delete of SaslAuthenticatorImpl object is atomic and thread safe.