Skip to content

DRILL-6846: Add CircleCI Test Summary#1678

Closed
vdiravka wants to merge 1 commit intoapache:masterfrom
vdiravka:DRILL-6846
Closed

DRILL-6846: Add CircleCI Test Summary#1678
vdiravka wants to merge 1 commit intoapache:masterfrom
vdiravka:DRILL-6846

Conversation

@vdiravka
Copy link
Member

@vdiravka vdiravka commented Mar 5, 2019

Example of Test Summary with BUILD SUCCESSFUL:
https://circleci.com/gh/vdiravka/drill/1013
Example of Test Summary with BUILD FAILURE:
https://circleci.com/gh/vdiravka/drill/1020

@vdiravka vdiravka requested a review from vvysotskyi March 5, 2019 01:08
@arina-ielchiieva
Copy link
Member

@vvysotskyi please review.

Copy link
Member

@vvysotskyi vvysotskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, +1

- added CircleCI Test Summary
- maven-surefire-plugin version udpate
- license checkstyle goal is added to the TravisCI protobuf phase
@vdiravka
Copy link
Member Author

vdiravka commented Mar 5, 2019

@vvysotskyi I have also added license checkstyle goal to the TravisCI protobuf phase: -Drat.skip=false -Dlicense.skip=false. It was missed in DRILL-7031
Please review.

@vvysotskyi
Copy link
Member

Thanks for catching this! +1

lushuifeng pushed a commit to lushuifeng/drill that referenced this pull request Jun 21, 2019
closes apache#1678
- added CircleCI Test Summary
- maven-surefire-plugin version udpate
- license checkstyle goal is added to the TravisCI protobuf phase
xiangt920 pushed a commit to xiangt920/drill that referenced this pull request Dec 26, 2019
closes apache#1678
- added CircleCI Test Summary
- maven-surefire-plugin version udpate
- license checkstyle goal is added to the TravisCI protobuf phase
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants