DRILL-7343: Add User-Agent UDFs to Drill#1840
Conversation
contrib/udfs/src/main/java/org/apache/drill/exec/udfs/UserAgentFunctions.java
Outdated
Show resolved
Hide resolved
contrib/udfs/src/main/java/org/apache/drill/exec/udfs/UserAgentFunctions.java
Show resolved
Hide resolved
contrib/udfs/src/test/java/org/apache/drill/exec/udfs/TestUserAgentFunctions.java
Outdated
Show resolved
Hide resolved
contrib/udfs/src/test/java/org/apache/drill/exec/udfs/TestUserAgentFunctions.java
Outdated
Show resolved
Hide resolved
contrib/udfs/src/test/java/org/apache/drill/exec/udfs/TestUserAgentFunctions.java
Outdated
Show resolved
Hide resolved
|
@KazydubB In any event, this seems like horrible design. I'm going to open a JIRA to create a new function handler which returns an empty list on null. That seems like a better approach than having to write 2 UDFS for every UDF with a complex writer output. I also added a series of unit tests to test this functionality. |
|
@cgivre I agree that having two functions for |
|
@KazydubB I opened a JIRA for the null issues, but this PR should be ready to go. |
arina-ielchiieva
left a comment
There was a problem hiding this comment.
@cgivre overall looks good, please fix minor remaining issues (including extra or missing spaces) and PR will be ready to go.
contrib/udfs/src/test/java/org/apache/drill/exec/udfs/TestUserAgentFunctions.java
Outdated
Show resolved
Hide resolved
contrib/udfs/src/test/java/org/apache/drill/exec/udfs/TestUserAgentFunctions.java
Outdated
Show resolved
Hide resolved
contrib/udfs/src/test/java/org/apache/drill/exec/udfs/TestUserAgentFunctions.java
Outdated
Show resolved
Hide resolved
contrib/udfs/src/test/java/org/apache/drill/exec/udfs/TestUserAgentFunctions.java
Outdated
Show resolved
Hide resolved
contrib/udfs/src/main/java/org/apache/drill/exec/udfs/UserAgentFunctions.java
Outdated
Show resolved
Hide resolved
0605d37 to
81c9945
Compare
920071f to
b27d244
Compare
|
Looks good, +1 |
These UDFs add the ability to parse user agent strings, which is useful for security data analysis.