Closed
Conversation
Contributor
|
Can you break each of these commits into its own jira? It is confusing that you are doing a bunch of independent commits under the same jira number. |
Contributor
Author
|
This is now https://issues.apache.org/jira/browse/DRILL-3920 . |
Contributor
There was a problem hiding this comment.
the logic in clear() seems duplicating close(). we should directly call close perhaps.
Contributor
Author
There was a problem hiding this comment.
But clear() doesn't call vectors.clear(). I seem to recall a problem with adding that to clear() in the past. I'm worried this will introduce a regression, so I'd rather not take that change on now.
Additional tests added to TestValueVectors for serialization and loading. Some light cleanup of a few vector implementations.
3b5e0bd to
2a4bd05
Compare
Contributor
Author
|
I made the changes indicated above, but not any that might destabilize tests (noted above). Please re-review and merge. |
Contributor
|
+1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Additional tests added to TestValueVectors for serialization and loading; these tests were used to find and debug issues with DrillBuf slicing. Some light cleanup of a few vector implementations.
Unit tests pass.
Regression suite has a few (known recurring) failures: