Skip to content

Typo Rectified#2086

Merged
jnturton merged 1 commit into
apache:gh-pagesfrom
swattu:patch-1
Jan 15, 2021
Merged

Typo Rectified#2086
jnturton merged 1 commit into
apache:gh-pagesfrom
swattu:patch-1

Conversation

@swattu
Copy link
Copy Markdown
Contributor

@swattu swattu commented Jun 11, 2020

DRILL-XXXX: PR Title

(Please replace PR Title with actual PR Title)

Description

(Please describe the change. If more than one ticket is fixed, include a reference to those tickets.)

Documentation

(Please describe user-visible changes similar to what should appear in the Drill documentation.)

Testing

(Please describe how this PR has been tested.)

@sanel
Copy link
Copy Markdown

sanel commented Jun 18, 2020

Here are few more suggestions

--- 060-querying-the-information-schema.md.old	2020-06-18 09:51:39.640215255 +0200
+++ 060-querying-the-information-schema.md	2020-06-18 09:51:50.553274730 +0200
@@ -74,11 +74,11 @@
 The VIEWS table returns the name and definition for each view in your
 databases. Note that file schemas are the canonical repository for views in
 Drill. Depending on how you create a view, they may only be displayed in Drill
-after it has been used.
+after being used.
 
 ## PARTITIONS
 
-The PARTITIONS table returns information about table partitions including partition columns, partition keys, etc. for each table.
+The PARTITIONS table returns information about table partitions, including partition columns, partition keys, etc. for each table.
 
 ## FILES
 
@@ -142,7 +142,7 @@
 	| DRILL         | s3_years_bucket.root     | <owner>       | file  | NO          |
 	+---------------+--------------------------+---------------+-------+-------------+  
 
-Querying the FILES table and filtering on the SCHEMA_NAME provides information about the files that exist within a workspace:  
+Querying the FILES table and filtering on the SCHEMA_NAME provides information about the files within a workspace:  
 
 **Note:** The word “files” is a reserved word in Drill and requires backticks (``).   
 
@@ -235,7 +235,7 @@
 ### TABLES Queries
 
 Run an ``INFORMATION_SCHEMA.`TABLES` ``query to view all of the tables and views
-
+within a database. TABLES is a reserved word in Drill and requires backticks
 (`).
 
 For example, the following query identifies all of the tables and views that

@cgivre cgivre added the documentation PRs relating to documentation label Jan 10, 2021
@cgivre
Copy link
Copy Markdown
Contributor

cgivre commented Jan 10, 2021

@dzamo Are you ok with committing this?

@jnturton jnturton merged commit ca5d8cd into apache:gh-pages Jan 15, 2021
@jnturton
Copy link
Copy Markdown
Contributor

Thank you @swattu and @sanel, I've incorporated your contributions. Some notes for future contributors follow.

  • We don't require Drill's JIRA-based PR template for documentation destined for gh-pages.
  • Sending documentation as commits helps us more than sending it as Github comments.
  • If you can cast around for 15 minutes and send a handful of fixes or additions in your PR that helps more than a PR to fix a single typo. We do know that time is scarce and we are grateful for any you can spare.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation PRs relating to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants