Skip to content

Documentation updates for 1.18#2096

Merged
jnturton merged 35 commits intoapache:gh-pagesfrom
jnturton:gh-pages
Dec 10, 2020
Merged

Documentation updates for 1.18#2096
jnturton merged 35 commits intoapache:gh-pagesfrom
jnturton:gh-pages

Conversation

@jnturton
Copy link
Copy Markdown
Contributor

@jnturton jnturton commented Aug 10, 2020

Numerous contributions to bring the Drill documentation up to speed with release 1.18.

Copy link
Copy Markdown
Contributor

@cgivre cgivre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow! Lots here...
Ok.. A few nits, but one organization comment.
Can we please move the format plugin info to the section about querying files?

@cgivre cgivre added the documentation PRs relating to documentation label Aug 10, 2020
@cgivre cgivre assigned cgivre and unassigned cgivre Aug 10, 2020
@cgivre
Copy link
Copy Markdown
Contributor

cgivre commented Aug 10, 2020

One more thing... take a look here https://github.com/apache/drill/tree/master/contrib/udfs for UDFs included with Drill. Ideally these should be in the docs.

@cgivre
Copy link
Copy Markdown
Contributor

cgivre commented Sep 13, 2020

@dzamo
Any update?
Thanks

@jnturton
Copy link
Copy Markdown
Contributor Author

jnturton commented Sep 16, 2020 via email

@cgivre
Copy link
Copy Markdown
Contributor

cgivre commented Oct 21, 2020

Hi @dzamo
I hope all is well. Do you have any update on this? Should we just go ahead and commit?

@jnturton
Copy link
Copy Markdown
Contributor Author

jnturton commented Oct 21, 2020

@cgivre If this isn't holding anything back and we can wait a few more days then let us, because I certainly have more to add, including the requested changes. My apologies for the stalling. As COVID-19 lockdown lifted where I am, a period of intense travelling ensued. But it concluded at the start of this week.

@cgivre
Copy link
Copy Markdown
Contributor

cgivre commented Oct 21, 2020

@dzamo
Thanks for getting back with me. Would a week or so be a reasonable timetable for next review?

@jnturton
Copy link
Copy Markdown
Contributor Author

jnturton commented Oct 21, 2020

@cgivre
Yes, that works for me.

@jnturton
Copy link
Copy Markdown
Contributor Author

jnturton commented Nov 3, 2020

@cgivre: I think that may just be a wrap.

See https://jekyllrb.com/docs/permalinks/ for why docs/:title doesn't
give the desired permalinks.
Having slug: lines, even if they are identical to the :title lines,
produces correct permalinks.

Removing date: lines stops Jekyll from sorting the docs collection by
date and resinstates the intended path-based sorting which means that
the file name numebring prefix scheme once again works.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation PRs relating to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants