minor doc fixes #2178
Closed
minor doc fixes #2178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vvysotskyi
requested changes
Feb 22, 2021
| * More example queries and sample data | ||
| * Find out ways to be involved or discuss Drill | ||
| * Remote Execution Installation Instructions | ||
| * [Running Drill on Docker instructions](docs/dev/Docker.md) |
Member
There was a problem hiding this comment.
Initially, the link was correct, but for some reason, it became broken... Could you please instead fix the page for the Drill website? Here is the corresponding doc: https://github.com/apache/drill/blob/gh-pages/_docs/install/installing-drill-in-embedded-mode/011-running-drill-on-docker.md
We shouldn't use the relative link here since this README.md is also displayed in https://hub.docker.com/r/apache/drill and this link will be broken there.
Author
There was a problem hiding this comment.
Ok got it. As this seems to be an issue related to another branch, so I'll have to close this ticket and then make another pr for the gh-pages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Extremely minor. Just wanted to update the running on dockers link as there was some confusion about the dockers link on slack.
I'm kind of confused with some of these changes because I did not touch them but apparently I deleted and re-added them.