DRILL-4056: Avro corruption bug with UTF-8 strings #266
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed use of unnecessary Holder objects. Added restriction on batch size produced by a single call to next. Did not get a chance to confirm but it looks like it was reading an entire file into a single batch, which could have serious performance impacts on very large files.
Task to be finished as part of DRILL-4110.
jaltekruse
force-pushed
the
4056-avro-corruption-bug
branch
from
dc084c1 to
666d1ed
Compare
Contributor
Author
|
This was merged into the 1.3 release branch, but I just realized it was not merged into master. Will get it in shortly. |
jaltekruse
added a commit
to jaltekruse/incubator-drill
that referenced
this pull request
Nov 25, 2015
- Fix issue where we are reading a byte array without considering length - Removed use of unnecessary Holder objects. - Added restriction on batch size produced by a single call to next. - Add some basic result verification to avro tests. This closes apache#266
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.