DRILL-4142: Query/Node memory maximums #284
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- make Allocator mostly lockless - change BaseAllocator maps to direct references - add documentation around memory management model - move transfer and ownership methods to DrillBuf
Fix issue where we were under reference-counting Update accountant to avoid reservation limit failure incorrect accounting.
- Add new AllocatorDecorator helper class. - Update BaseAllocator/BufferAllocator to support unwrap(Class<T>) functionality - Create a new QueryAllocator that survives as long as at least one fragment allocator exists. - Expose synchronized QueryAllocator creation per node via the WorkEventBus - Expose a new SYSTEM-only option: "exec.memory.max.per_query_per_node.mb" with a default of 1TB.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple Query-level allocator design. Can be enhanced via better workload management flow.