DRILL-4246: Fix Allocator concurrency bug and improve error detection#323
Closed
jacques-n wants to merge 1 commit intoapache:masterfrom
Closed
DRILL-4246: Fix Allocator concurrency bug and improve error detection#323jacques-n wants to merge 1 commit intoapache:masterfrom
jacques-n wants to merge 1 commit intoapache:masterfrom
Conversation
- Rename the internal DrillBuf field to udle to better express its purpose. - Rename AllocatorManager to AllocationManager to better express its purpose. - Address situation where dangling ledger could be transferred into while it was being released released by protecting association and release inside the AllocationManager. - Add allocator assertions to ensure allocator operations are done while the allocator is open. - Simplify AllocationManager locking model. - Exclude HDFS reference to netty-all - Improve debugging messages for allocators (and fix debug message bugs)
Contributor
Author
|
Passes unit and regression suites |
Contributor
There was a problem hiding this comment.
Comment needs to be updated
Contributor
|
LGTM. +1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests pending but evaluation shows previously frequently failing flatten tests to consistently pass.