Drill 2517: Apply directory-based partition pruning before reading files in planning.#328
Closed
jinfengni wants to merge 4 commits intoapache:masterfrom
Closed
Drill 2517: Apply directory-based partition pruning before reading files in planning.#328jinfengni wants to merge 4 commits intoapache:masterfrom
jinfengni wants to merge 4 commits intoapache:masterfrom
Conversation
jinfengni
force-pushed
the
DRILL-2517
branch
4 times, most recently
from
4142787 to
29e2555
Compare
There was a problem hiding this comment.
It's not clear to me why a flag is needed to keep track of Calcite logical...ideally this should be handled by the type of the RelNode. We may need to do some refactoring of this rule to separate out the ones that apply during Calcite logical planning vs. Drill logical planning.
Contributor
Author
There was a problem hiding this comment.
You are right. The flag is not needed now. I will refactor the rules.
jinfengni
force-pushed
the
DRILL-2517
branch
2 times, most recently
from
ec5bd95 to
d03a075
Compare
| final FileGroupScan newScan = ((FileGroupScan)scanRel.getGroupScan()).clone(newSelection); | ||
| return newScan; | ||
| // @Override | ||
| // public GroupScan createNewGroupScan(List<String> newFiles) throws IOException { |
There was a problem hiding this comment.
This function can be removed completely...
|
Revised patch looks good to me..other than a few minor comments. +1. |
…uning to logical phase.
… planning phase. 1) Make directory-based pruning rule both work in calcite logical and drill logical planning phase. 2) Only apply directory-based pruning in logical phase when there is no metadata cache. 3) Make FileSelection constructor public, since FileSelection.create() would modify selectionRoot.
Contributor
Author
|
this PR has been merged to drill 1.6.0. Close this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SELECT count(*) from T1 where dir0 = 1990 and dir1 = 'Q1'.
@amansinha100 , could you please take a look and give some initial review comments? Thanks!