DRILL-4237 DRILL-4478 fully implement hash to use murmur3 and correspondent unit tests #408
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ondent unit tests
Contributor
Author
|
As to the test code that use original cpp implementation to generate the test vectors in murmur3_buf.json and murmur3_double.json. Please refer to here: |
… correspondent unit tests" This reverts commit 72773e7.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1, Implement Murmur3 to work on DrillBuf and long(double), both avoid object or extra buffer creation.
2, Point hash functions in hash32, hash64, hash32AsDouble and hash64AsDouble to HashHelper.hash32|64
3, Test Correctness of the hash functions b comparing with original c implmementation's generated hash results.
4, Adding tests to cover Hash**WithSeed.
5, Fix DRILL-4478 which prevent binar_string function working correctly.