DRILL-4571: Add link to local Drill logs from the web UI #472
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| /** | ||
| * Web settings | ||
| */ | ||
| String WEB_LOGS_MAX_LINES = "drill.web.logs.max_lines"; |
Contributor
There was a problem hiding this comment.
Should use system option. Anything that isn't bootstrap should be kept out of *.conf
Member
Author
There was a problem hiding this comment.
Agree. Updated PR.
arina-ielchiieva
force-pushed
the
DRILL-4571
branch
from
d6c5c66 to
162b40b
Compare
arina-ielchiieva
force-pushed
the
DRILL-4571
branch
from
162b40b to
98a19f6
Compare
Contributor
|
+1. LGTM |
parthchandra
pushed a commit
to parthchandra/drill
that referenced
this pull request
Oct 21, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.