DRILL-4510: Revert DRILL-4476 since UnionAllRecordBatch cannot determ…#498
Closed
hsuanyi wants to merge 1 commit intoapache:masterfrom
Closed
DRILL-4510: Revert DRILL-4476 since UnionAllRecordBatch cannot determ…#498hsuanyi wants to merge 1 commit intoapache:masterfrom
hsuanyi wants to merge 1 commit intoapache:masterfrom
Conversation
…ine if a given record batch is from an empty file or not, just according to the number of rows
Contributor
|
@hsuanyi Reading the JIRA it looks like the flakey test this revert was trying to fix was resolved a while ago since we have not been seeing it for some time. Also the code in UnionAllRecordBatch has changed significantly so this revert no longer applies. I will close this PR, but please feel free to reopen if you feel there is something that needs to be addressed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ine if a given record batch is from an empty file or not, just according to the number of rows