DRILL-5058: External sort does not handle its own UserExceptions#664
Closed
paul-rogers wants to merge 1 commit intoapache:masterfrom
Closed
DRILL-5058: External sort does not handle its own UserExceptions#664paul-rogers wants to merge 1 commit intoapache:masterfrom
paul-rogers wants to merge 1 commit intoapache:masterfrom
Conversation
Solution is to catch the exception, clean up, and fail the operator.
Contributor
Author
|
Hold off on this for a bit. It turns out that the proper handling of exceptions is a bit murky. Should a UserException be handled locally in each operator (as are all other exceptions?) That's what this fix does. Or, should all other exceptions be translated to a UserException and thrown up the stack? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solution is to catch the exception, clean up, and fail the operator.
Test case is the existing {{TestSortSpillWithException}} test case.