Bugs/various work re master 07 09#87
Closed
dsbos wants to merge 51 commits intoapache:masterfrom
dsbos:bugs/various_WORK_re_master_07-09
Closed
Bugs/various work re master 07 09#87dsbos wants to merge 51 commits intoapache:masterfrom dsbos:bugs/various_WORK_re_master_07-09
dsbos wants to merge 51 commits intoapache:masterfrom
dsbos:bugs/various_WORK_re_master_07-09
Conversation
… in Review, < awaiting Merge Conflicts: pom.xml
Added ~unit test for ResultSetMetaData implementation. Made getObject return classes available to implementation of getColumnClassName: - Added SqlAccessor.getObjectClass() (to put that metadata right next to code to which it corresponds rather than in far-away parallel code). - Added similar AvaticaDrillSqlAccessor.getObjectClass(). - Changed DrillAccessorList.accessors from Accessor[] to AvaticaDrillSqlAccessor[] for better access to JDBC getObject return class. - Extracted return classes from accessors to pass to updateColumnMetaData. Reworked some data type mapping and utilities: - Added Added Types.getSqlTypeName(...). - Renamed Types.getJdbcType(...) to getJdbcTypeCode(...) - Replaced Types.isUnSigned with isJdbcSignedType. - Fixed various bogus RPC-type XXX -> java.sql.Types.SMALLINT mappings. - Removed DrillColumnMetaDataList.getJdbcTypeName. - Moved getAvaticaType up (for bottom-up order). - Revised DrillColumnMetaDataList.getAvaticaType(...). MAIN: - Updated updateColumnMetaData(...) to change many calculations of metadata input to ColumnMetaData construction. [DrillColumnMetaDataList] Updated other metadata tests per changes.
…llConfig, PathScanner] Renamed constants. Documented constants. Removed extraneous "public static final" (redudant and abnormal since in interface).
Add some DEBUG-level log calls and augmented, edited log message. Misc. code "hygiene": - Added method doc comment. - Renamed to clarify a number of names. - Added "final". - Fixed indentation; wrapped some long lines.
…c/src/test/resources/logback.xml]
…ncurrencyEtc, TestTempAsyncCancelation3]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.