DRILL-5803: Show the hostname for each minor fragment in operator table#954
DRILL-5803: Show the hostname for each minor fragment in operator table#954kkhatua wants to merge 1 commit intoapache:masterfrom
Conversation
|
@paul-rogers Can you please review this minor UI update? |
paul-rogers
left a comment
paul-rogers
left a comment
There was a problem hiding this comment.
Nice feature! Very handy.
Key comment is a suggestion to simplify the implementation over the increasingly-convoluted lists-of-pairs implementation we use now.
| final List<OperatorWrapper> ows = new ArrayList<>(); | ||
| // temporary map to store (major_id, operator_id) -> [(op_profile, minor_id)] | ||
| final Map<ImmutablePair<Integer, Integer>, List<ImmutablePair<OperatorProfile, Integer>>> opmap = new HashMap<>(); | ||
| // temporary map to store (major_id, operator_id) -> [minorFragHostname] |
There was a problem hiding this comment.
Effectively, what this is doing is converting the opmap from a map of immutable pairs to a map of immutable triples. About here, we might want to restructure the map to point to a class which holds the two elements in the first pair, plus the host name.
Why? Simpler. Easier to keep class fields in sync than to keep two separate lists in sync.
There was a problem hiding this comment.
+1 on this comment. However, I didn't what to make the PR look to radically alter what is already there. I'll incorporate the change. This should go nicely with a fix for DRILL-5802 and make life a bit easier
Based on DRILL-4909, list hostnames for each minor fragment within an operator table to identify any problematic host
|
@paul-rogers Made the changes |
|
The fixes are an improvement. In some future commit, an actual class would be better than nested immutable pairs. At present, the code has become a bit cryptic and Python-like. But, we can do that improvement later. |
Based on DRILL-4909, list hostnames for each minor fragment within an operator table to identify any problematic host closes apache#954
2 participants
Based on DRILL-4909, list hostnames for each minor fragment within an operator table to identify any problematic host