DRILL-5755 Reduced default number of batches kept in memory by TopN #964
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
paul-rogers
approved these changes
Oct 1, 2017
Contributor
paul-rogers
left a comment
paul-rogers
left a comment
There was a problem hiding this comment.
This is certainly a simple fix!
+1
ilooner
added a commit
to ilooner/drill
that referenced
this pull request
Oct 18, 2017
…pN operator. closes apache#964
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change prevents the TopN operator from consuming large amounts of memory by default. This is important since the TopN operator doesn't obey memory limits currently. This is not a true fix for the issue, but it will reduce the number of issues seen until a true fix is developed.