Remove references to datainfrahq GitHub Repo, remove operator-runtime dependency#5
Merged
abhishekrb19 merged 7 commits intoapache:masterfrom Mar 6, 2026
Merged
Conversation
License headers auditing should be included as part of ci/cd builds. This includes adding the Apache Rat audit tool and adds license headers
All six e2e/*.sh scripts were stored in git with mode 100644 (not executable), which caused the CI failure. Fixed with git update-index --chmod=+x to set mode 100755 in the git index, and chmod +x locally to match.
e2e/e2e.sh Two changes: 1. kind upgraded from v0.21.0 to v0.31.0 — the version previously installed was outdated. v0.31.0 is the current stable release. 2. PATH export added after go install — go install puts the kind binary in $(go env GOPATH)/bin, but that directory isn't always on $PATH in CI environments. Without this export, the kind command wouldn't be found immediately after install. 3. make kind-load-local and make kind-load-local-test added after the respective docker push calls — explained below under Makefile. --- e2e/kind.sh The containerdConfigPatches block was removed. That block configured a registry mirror inside the kind cluster so pods could pull images from the local registry at localhost:5001. It worked with containerd v1.x, but kindest/node:v1.35.0 (kind v0.31.0's default node image) ships with containerd v2.2.0, which removed that configuration API entirely. Applying the v1.x TOML patch to a v2.x containerd causes containerd to fail on startup, which in turn causes the kubelet to time out — the error seen in both local and CI runs. --- Makefile Two new targets added, and CONTROLLER_TOOLS_VERSION bumped: 1. kind-load-local and kind-load-local-test — these run kind load docker-image, which injects a local Docker image directly into the kind cluster's containerd image store, bypassing the need for a registry mirror entirely. This replaces what containerdConfigPatches used to do: instead of configuring containerd to pull from the local registry over the network, the image is pre-loaded directly. The chart already sets imagePullPolicy: IfNotPresent, so Kubernetes uses the pre-loaded image without attempting a network pull. 2. CONTROLLER_TOOLS_VERSION bumped from v0.14.0 to v0.20.1 — v0.14.0 depends on golang.org/x/tools@v0.16.1, which fails to compile with Go 1.25+ due to a negative array length constant bug. v0.20.1 is compatible.
AdheipSingh
approved these changes
Mar 5, 2026
abhishekrb19
reviewed
Mar 6, 2026
| with the License. You may obtain a copy of the License at | ||
|
|
||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
| http://www.apache.org/licenses/LICENSE-2.0 |
Contributor
There was a problem hiding this comment.
I believe the license checks on https://github.com/apache/druid project would flag whitespace inconsistencies as well.
abhishekrb19
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #XXXX.
Description
This PR has:
Key changed/added files in this PR
MyFooOurBarTheirBaz