Skip to content

Licensing and cleanup#6

Open
razinbouzar wants to merge 1 commit intoapache:masterfrom
razinbouzar:master
Open

Licensing and cleanup#6
razinbouzar wants to merge 1 commit intoapache:masterfrom
razinbouzar:master

Conversation

@razinbouzar
Copy link
Contributor

Further cleanup, fix licensing logic


  1. Added rat job (new)
    rat:
    runs-on: ubuntu-latest
    steps:

    • uses: actions/checkout@v4
    • name: Set up Java
      uses: actions/setup-java@v4
      with:
      distribution: temurin
      java-version: '11'
    • name: Run Apache RAT license audit
      run: make rat
      Runs Apache RAT on every push and PR to master. It runs in parallel with the tests job — if any file is missing a license
      header, the pipeline fails. Java is not pre-installed on GitHub runners, so actions/setup-java@v4 installs Temurin JDK 11
      before running make rat.
  2. actions/checkout@v2 → v4 in both jobs
    The original used checkout@v2 which runs on Node.js 16 (EOL). v4 uses Node.js 20, is actively maintained, and is the current
    recommended version.


config/rbac/role.yaml

Generated by controller-gen v0.20.1 (was v0.14.0). Two changes:

  1. RBAC rules compacted — resources that share the same verb set are now grouped together (e.g. configmaps,
    persistentvolumeclaims, pods, services under one rule block instead of four separate blocks). Functionally identical — same
    permissions, just deduplicated.
  2. events verbs narrowed — removed delete and update from events. The operator only needs to create/get/list/patch/watch
    events, not delete or update them. This is a correctness improvement from the newer generator.

chart/crds/druid.apache.org_druids.yaml

Also regenerated by controller-gen v0.20.1:

  1. Version annotation updated — v0.14.0 → v0.20.1 in the metadata
  2. TODO comments removed — several TODO: Add other useful fields. apiVersion, kind, uid? stubs that were left in by the older
    generator are now gone
  3. Extra blank lines removed — a few double blank lines within description: fields cleaned up

All changes are from the controller-gen upgrade — no functional impact on the CRD schema itself.

Fixes #XXXX.

Description


This PR has:

  • been tested on a real K8S cluster to ensure creation of a brand new Druid cluster works.
  • been tested for backward compatibility on a real K*S cluster by applying the changes introduced here on an existing Druid cluster. If there are any backward incompatible changes then they have been noted in the PR description.
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added documentation for new or modified features or behaviors.

Key changed/added files in this PR
  • MyFoo
  • OurBar
  • TheirBaz

Further cleanup, fix licensing logic
Copy link
Contributor

@AdheipSingh AdheipSingh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am assuming we have tested the CRD changes. Rest LGTM !

@razinbouzar
Copy link
Contributor Author

I am assuming we have tested the CRD changes. Rest LGTM !

CRD changes were tested locally using the e2e tests and make commands. Also tested locally by spinning up a cluster using minIO, which shows active running pods.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants