Open
Conversation
Further cleanup, fix licensing logic
AdheipSingh
approved these changes
Mar 7, 2026
Contributor
AdheipSingh
left a comment
There was a problem hiding this comment.
I am assuming we have tested the CRD changes. Rest LGTM !
Contributor
Author
CRD changes were tested locally using the e2e tests and make commands. Also tested locally by spinning up a cluster using minIO, which shows active running pods. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Further cleanup, fix licensing logic
Added rat job (new)
rat:
runs-on: ubuntu-latest
steps:
uses: actions/setup-java@v4
with:
distribution: temurin
java-version: '11'
run: make rat
Runs Apache RAT on every push and PR to master. It runs in parallel with the tests job — if any file is missing a license
header, the pipeline fails. Java is not pre-installed on GitHub runners, so actions/setup-java@v4 installs Temurin JDK 11
before running make rat.
actions/checkout@v2 → v4 in both jobs
The original used checkout@v2 which runs on Node.js 16 (EOL). v4 uses Node.js 20, is actively maintained, and is the current
recommended version.
config/rbac/role.yaml
Generated by controller-gen v0.20.1 (was v0.14.0). Two changes:
persistentvolumeclaims, pods, services under one rule block instead of four separate blocks). Functionally identical — same
permissions, just deduplicated.
events, not delete or update them. This is a correctness improvement from the newer generator.
chart/crds/druid.apache.org_druids.yaml
Also regenerated by controller-gen v0.20.1:
generator are now gone
All changes are from the controller-gen upgrade — no functional impact on the CRD schema itself.
Fixes #XXXX.
Description
This PR has:
Key changed/added files in this PR
MyFooOurBarTheirBaz