Skip to content

Update index.md#10396

Closed
tlblessing wants to merge 1 commit intoapache:masterfrom
tlblessing:patch-1
Closed

Update index.md#10396
tlblessing wants to merge 1 commit intoapache:masterfrom
tlblessing:patch-1

Conversation

@tlblessing
Copy link

Cool product.

Minor suggested copy edits.
-avoid excessive use of double quotes for terms that are well understood.
-avoid future tense when possible.
-missing punctuation.

Cool product
Copy link
Contributor

@jihoonson jihoonson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @tlblessing, thank you for your contribution! It looks good except the spell error which our spell check bot noticed 🙂. Would you please fix it?

    ../docs/design/index.md
       57 | ruid servers fail, the system automaticallys route around the damage until 
>> 1 spelling error found in 167 files


- Insert rates are very high, but updates are less common.
- Most of your queries are aggregation and reporting queries ("group by" queries). You may also have searching and
- Most of your queries are aggregation and reporting queries (group by queries). You may also have searching and
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually "group by" is the name of one of our query types. The doc mostly uses "groupBy". How about using the same notation here too?

@stale
Copy link

stale bot commented Nov 16, 2020

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this pull request should instead be reviewed, please simply write any comment. Even if closed, you can still revive the PR at any time or discuss it on the dev@druid.apache.org list. Thank you for your contributions.

@stale stale bot added the stale label Nov 16, 2020
@stale
Copy link

stale bot commented Dec 25, 2020

This pull request/issue has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.

@stale stale bot closed this Dec 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants