Any virtual column on "__time" should be a pre-join virtual column#10451
Merged
jon-wei merged 2 commits intoapache:masterfrom Oct 12, 2020
Merged
Any virtual column on "__time" should be a pre-join virtual column#10451jon-wei merged 2 commits intoapache:masterfrom
jon-wei merged 2 commits intoapache:masterfrom
Conversation
jon-wei
reviewed
Sep 29, 2020
Contributor
jon-wei
left a comment
jon-wei
left a comment
There was a problem hiding this comment.
Can you add a test? JoinFilterAnalyzerTest.test_filterPushDown_factToRegionToCountryLeftFilterOnChannelVirtualColumn is an example that uses virtual columns
jon-wei
approved these changes
Oct 12, 2020
JulianJaffePinterest
pushed a commit
to JulianJaffePinterest/druid
that referenced
this pull request
Jan 22, 2021
…pache#10451) * Virtual column on __time should be in pre-join * Add unit test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If there is a virtual column with
__timeand base table columns as required columns, the virtual column can still be created past join. This PR avoids that from happening.This PR has: