Skip to content

Add helm shield#10526

Merged
capistrant merged 1 commit intoapache:masterfrom
asdf2014:helm_shield
Nov 10, 2020
Merged

Add helm shield#10526
capistrant merged 1 commit intoapache:masterfrom
asdf2014:helm_shield

Conversation

@asdf2014
Copy link
Member

Description

Add helm shield Helm


This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

@asdf2014 asdf2014 added Area - Documentation Helm Chart https://github.com/apache/druid/tree/master/helm/druid labels Oct 22, 2020
Copy link
Contributor

@capistrant capistrant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is the official helm chart for Druid, I think this is a good addition

@capistrant capistrant merged commit f1b5745 into apache:master Nov 10, 2020
@jihoonson jihoonson added this to the 0.21.0 milestone Jan 4, 2021
JulianJaffePinterest pushed a commit to JulianJaffePinterest/druid that referenced this pull request Jan 22, 2021
@asdf2014 asdf2014 deleted the helm_shield branch February 13, 2021 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area - Documentation Helm Chart https://github.com/apache/druid/tree/master/helm/druid

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants