Skip to content

update syntax for golbal cached uri lookups#10629

Merged
suneet-s merged 1 commit intoapache:masterfrom
techdocsmith:lookup-syntax
Dec 24, 2020
Merged

update syntax for golbal cached uri lookups#10629
suneet-s merged 1 commit intoapache:masterfrom
techdocsmith:lookup-syntax

Conversation

@techdocsmith
Copy link
Contributor

Fixes an issue with the syntax for columns in cached global lookups

Description

Updates the docs to be inline with the syntax displayed in the Druid UI.

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

Copy link
Contributor

@suneet-s suneet-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@suneet-s suneet-s merged commit 7973715 into apache:master Dec 24, 2020
@jihoonson jihoonson added this to the 0.21.0 milestone Jan 4, 2021
JulianJaffePinterest pushed a commit to JulianJaffePinterest/druid that referenced this pull request Jan 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants