[Minor Doc Fix] Correct the default value of druid.server.http.gracefulShutdownTimeout#10661
Merged
jihoonson merged 3 commits intoapache:masterfrom Jan 8, 2021
Conversation
a2l007
approved these changes
Dec 9, 2020
Contributor
a2l007
left a comment
There was a problem hiding this comment.
Thanks for the fix!
I guess if we indeed do want to support shutdown without waiting, we might need another config property to toggle setStopAtShutdown. But I doubt the need for such a config as druid.server.http.gracefulShutdownTimeout satisfies most of the usecases.
Contributor
Author
|
@a2l007 Thanks for your review! |
jihoonson
approved these changes
Jan 8, 2021
Contributor
I agree. The current config seems enough. |
JulianJaffePinterest
pushed a commit
to JulianJaffePinterest/druid
that referenced
this pull request
Jan 22, 2021
…fulShutdownTimeout` (apache#10661) * done * done * done Co-authored-by: yuezhang <yuezhang@freewheel.tv>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
According to the code
druid/server/src/main/java/org/apache/druid/server/initialization/jetty/JettyServerModule.java
Line 365 in 94226f1
druid/server/src/main/java/org/apache/druid/server/initialization/jetty/JettyServerModule.java
Line 366 in 94226f1
druid/server/src/main/java/org/apache/druid/server/initialization/jetty/JettyServerModule.java
Line 367 in 94226f1
The configuration
druid.server.http.gracefulShutdownTimeoutcan only take effect when the user sets a value greater than zero. Otherwise this parameter will not be set, using the default value which is 30000 milliseconds(PT30S) coding inhttps://github.com/eclipse/jetty.project/blob/jetty-9.4.34.v20201102/jetty-util/src/main/java/org/eclipse/jetty/util/component/AbstractLifeCycle.java#L53
This PR has:
Key changed/added classes in this PR
index.md