Add documentation re alphabetical sorted of MV dimensions#10695
Add documentation re alphabetical sorted of MV dimensions#10695clintropolis merged 1 commit intoapache:masterfrom
Conversation
techdocsmith
left a comment
There was a problem hiding this comment.
See comments. Please fix link style.
docs/ingestion/index.md
Outdated
There was a problem hiding this comment.
| | multiValueHandling | Specify the type of handling multi-value fields will get, possible values are `SORTED_ARRAY`, `SORTED_SET` and `ARRAY`. The first two will order the array upon ingestion and `SORTED_SET` will remove duplicates. `ARRAY` will ingest data as-is | `SORTED_ARRAY` | | |
| | multiValueHandling | Specify the type of handling for multi-value fields. Possible values are `SORTED_ARRAY`, `SORTED_SET`, and `ARRAY`. `SORTED_ARRAY` and `SORTED_SET` order the array upon ingestion. `SORTED_SET` removes duplicates. `ARRAY` ingests data as-is | `SORTED_ARRAY` | |
There was a problem hiding this comment.
| characters), by default they are sorted alphabetically, see [Dimension Objects](../ingestion/index.html#dimension-objects) for configuration. | |
| characters), by default Druid lists the values in alphabetical order, see [Dimension Objects](../ingestion/index.md#dimension-objects) for configuration. |
Please use .md for links. Also, it's not clear to me what the related information is at the destination. But I'm a still fairly new to Druid.
There was a problem hiding this comment.
Thanks @techdocsmith, I've updated the commit with your recommendations. "Lists" is the wrong verb here, "ingests" would be more appropriate. The referred section is the above committed detail about multiValueHandling.
There was a problem hiding this comment.
Also .md should be .html, check the rest of the reference in the file. The markdown is compiled for the web version of the doc.
There was a problem hiding this comment.
Thanks for the context @techdocsmith, I've changed it to .md
bb0ebb0 to
77595db
Compare
gianm
left a comment
There was a problem hiding this comment.
I double-checked to make sure there are tests for this feature, and it looks like there are, so I think it's good to add the docs. (We wouldn't want to add docs for an untested feature!)
A couple of comments and then I think this is good to go.
Probably ARRAY or maybe SORTED_SET would be an ideal default. SORTED_ARRAY is a little weird, admittedly, but it's the default for legacy reasons. Maybe we'll change it in a future version. |
|
Thanks @gianm. Requested changes added |
Simple updating of documentation. It's very relevant to know that that multi-value dimensions are sorted by default and that it's possible to change this behaviour.
To someone more intune with Druid's inner workings: Do we really want alphabetical sorted to be the default for MV dimensions? Would it not be better to default to
ARRAYin DimensionSchema L89?Description
Fixed the bug ...
Renamed the class ...
Added a forbidden-apis entry ...
This PR has:
Key changed/added classes in this PR
MyFooOurBarTheirBaz