Skip to content

Add missing unit tests for segment loading in historicals#10737

Merged
jon-wei merged 3 commits intoapache:masterfrom
jihoonson:unit-tests-for-10650
Jan 12, 2021
Merged

Add missing unit tests for segment loading in historicals#10737
jon-wei merged 3 commits intoapache:masterfrom
jihoonson:unit-tests-for-10650

Conversation

@jihoonson
Copy link
Contributor

@jihoonson jihoonson commented Jan 8, 2021

Description

This PR adds missing unit tests for the changes made in #10650.

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

@jihoonson jihoonson mentioned this pull request Jan 8, 2021
Merged
9 tasks
@zhangyue19921010
Copy link
Contributor

zhangyue19921010 commented Jan 9, 2021 •
edited
Loading

Thanks for adding this UT. LGTM :)

zhangyue19921010
zhangyue19921010 approved these changes Jan 9, 2021
View reviewed changes
server/src/test/java/org/apache/druid/server/coordination/SegmentLoadDropHandlerTest.java Outdated
import org.apache.druid.segment.loading.StorageLocationConfig;
import org.apache.druid.server.SegmentManager;
import org.apache.druid.server.coordination.SegmentLoadDropHandler.DataSegmentChangeRequestAndStatus;
import org.apache.druid.server.coordination.SegmentLoadDropHandler.Status;
Copy link
Contributor

@zhangyue19921010 zhangyue19921010 Jan 9, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Need to remove this unused import.
import org.apache.druid.server.coordination.SegmentLoadDropHandler.Status;

Copy link
Contributor Author

@jihoonson jihoonson Jan 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, thanks!

a2l007
a2l007 approved these changes Jan 11, 2021
View reviewed changes
Copy link
Contributor

@a2l007 a2l007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jon-wei jon-wei merged commit 3984457 into apache:master Jan 12, 2021
JulianJaffePinterest pushed a commit to JulianJaffePinterest/druid that referenced this pull request Jan 22, 2021
@jihoonson @JulianJaffePinterest
Add missing unit tests for segment loading in historicals (apache#10737)
aa30273 
* Add missing unit tests for segment loading in historicals

* unused import
@jihoonson jihoonson added this to the 0.21.0 milestone Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@a2l007 a2l007 a2l007 approved these changes

@jon-wei jon-wei jon-wei approved these changes

@zhangyue19921010 zhangyue19921010 zhangyue19921010 approved these changes

Assignees

No one assigned

Labels

Area - Testing

Projects

None yet

Milestone

0.21.0

Development

Successfully merging this pull request may close these issues.

4 participants

@jihoonson @zhangyue19921010 @a2l007 @jon-wei