Skip to content

SegmentAnalyzer: Properly close column after retrieving it.#10772

Merged
clintropolis merged 1 commit intoapache:masterfrom
gianm:close-column-in-segment-analyzer
Jan 17, 2021
Merged

SegmentAnalyzer: Properly close column after retrieving it.#10772
clintropolis merged 1 commit intoapache:masterfrom
gianm:close-column-in-segment-analyzer

Conversation

@gianm
Copy link
Contributor

@gianm gianm commented Jan 16, 2021

To avoid resource leaks, columns retrieved from a ColumnHolder should be closed after being used.

@gianm gianm added the Bug label Jan 16, 2021
Copy link
Member

@clintropolis clintropolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤘

@clintropolis clintropolis merged commit 2b24dc3 into apache:master Jan 17, 2021
@gianm gianm deleted the close-column-in-segment-analyzer branch January 17, 2021 04:21
JulianJaffePinterest pushed a commit to JulianJaffePinterest/druid that referenced this pull request Jan 22, 2021
@clintropolis clintropolis added this to the 0.22.0 milestone Aug 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants