Web console: use new example manifest#10787
Merged
vogievetsky merged 1 commit intoapache:masterfrom Jan 24, 2021
Merged
Conversation
Contributor
Author
|
Thank you for the review, this simple change should ideally go into 0.21.0 release |
jihoonson
pushed a commit
to jihoonson/druid
that referenced
this pull request
Feb 2, 2021
jihoonson
added a commit
that referenced
this pull request
Feb 2, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a tiny change to direct the console to use the newer example manifest file that was added here: apache/druid-website-src#202 (please make sure that PR is merged before this one!).
The issue this solves is that https://github.com/apache/druid-website-src/blob/master/data/example-manifests.tsv had a spec that hard coded the name of the data source to
new_data_sourceand the console will no longer overwrite it. This means that without this change if the user goes through the example flow and just clicksNextover and over (as most do) they will get a data source callednew_data_sourceinstead ofwikipediaas they would have done before. This will cause needless confusion.