HTTP inputSource should deny all domains by default#10840
Closed
jihoonson wants to merge 1 commit intoapache:masterfrom
Closed
HTTP inputSource should deny all domains by default#10840jihoonson wants to merge 1 commit intoapache:masterfrom
jihoonson wants to merge 1 commit intoapache:masterfrom
Conversation
himanshug
approved these changes
Feb 3, 2021
Contributor
|
@jihoonson shall this be merged? |
|
This pull request has been marked as stale due to 60 days of inactivity. |
|
This pull request/issue has been closed due to lack of activity. If you think that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In the current Druid security model, the people who can ingest data are usually system administrators or trusted users because they will get the same privilege as what the Overlord has. However, when ingest permission is granted to a non-trusted user for some reason, it could be problematic if that user can ingest from any domains using HTTP inputSource. This PR changes HTTP inputSource to deny access to all domains by default. This can be a good practice for system admins to think about what domains they want to allow before using HTTP inputSource.
This PR has: