Filter unauthorized views in InformationSchema#10874
Merged
jon-wei merged 3 commits intoapache:masterfrom Feb 17, 2021
Merged
Conversation
| final AuthorizerMapper authorizerMapper, | ||
| @DruidSchemaName String druidSchemaName | ||
| @DruidSchemaName String druidSchemaName, | ||
| @ViewSchemaName String viewSchemaName |
Member
There was a problem hiding this comment.
I guess NamedViewSchema should probably use this injected name instead of its own name, and also SqlResourceCollectorShuttle should probably accept it as well since it does for druid schema name.
Contributor
Author
There was a problem hiding this comment.
It would take some additional changes in DruidPlanner and beyond to support passing in the view name, so I decided to just use a fixed name for the view schema, I don't think the additional complexity is worth it currently.
clintropolis
approved these changes
Feb 11, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adjusts the InformationSchema class such that it properly filters out views based on authorization checks. Previously it checked the view subschema against the "druid" schema name, and thus fell back on the unfiltered path.
This PR has: