Update dependency-check plugin#10883
Merged
suneet-s merged 2 commits intoapache:masterfrom Feb 17, 2021
Merged
Conversation
capistrant
approved these changes
Feb 16, 2021
Contributor
capistrant
left a comment
There was a problem hiding this comment.
I'm cool with this. It will be interesting to see how the lack of reporting in CI itself will effect the mood of devs when they realize they need to generate the report locally and then share results :)
but I think it is acceptable trade-off for increased stability of CI
Contributor
Author
|
I didn't find this too bad when I was looking for failures. Hopefully we have to look at these warnings a lot less frequently now if it's less flaky :) |
Contributor
Author
|
So it turns out I was wrong. It was hard to know that an actual CVE was flagged because this job had been flaky in the past. I'll create a follow up PR with a better error message so that it makes it more obvious what should be done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to make the dependency-check job less flaky. It addresses intermittent failures with error messages like
Failed to request component-reportsThis was inspired by the workaround suggested in jeremylong/DependencyCheck#1908
Local testing appears to support the workaround mentioned in this issue.
The drawback of this approach is that the job will no longer produce a dependency vulnerability report - so if the job fails, devs need to run
mvn dependency-check:checklocally to see which project the vulnerability is reported from.This PR also updates the version to the latest. The upgrade from 5.x to 6.x is a breaking change for some use cases, but AFAICT nothing was needed as part of the version upgrade.
This PR has: