fix ClassCastException when finalize hyperUnique metric in sql#10899
Closed
kaijianding wants to merge 1 commit intoapache:masterfrom
Closed
fix ClassCastException when finalize hyperUnique metric in sql#10899kaijianding wants to merge 1 commit intoapache:masterfrom
kaijianding wants to merge 1 commit intoapache:masterfrom
Conversation
Contributor
Author
|
The CI failure |
Member
clintropolis
left a comment
There was a problem hiding this comment.
Change looks good to me, any chance you can add a test that covers this case?
|
Is this merged or just deleted? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
for a sql like this
unique_user_id is hyperUnique metric.
java.lang.ClassCastException is thrown as
The reason is that
count(distinct unique_user_id)is Long in row signature, but the comparator inHyperUniqueFinalizingPostAggregatoris DoubleThis PR has:
Key changed/added classes in this PR
HyperUniqueFinalizingPostAggregator