Skip to content

allow multiple ldap bootstrap files for integration tests#11023

Merged
jihoonson merged 1 commit intoapache:masterfrom
jihoonson:ldap-bootstrap
Mar 23, 2021
Merged

allow multiple ldap bootstrap files for integration tests#11023
jihoonson merged 1 commit intoapache:masterfrom
jihoonson:ldap-bootstrap

Conversation

@jihoonson
Copy link
Contributor

Description

This PR allows the LDAP integration tests to read multiple bootstrap files so that you can add more configuration files for testing your custom extensions. It also changes the host port bound for metadata store as it can conflict when you have mysql running.


This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

Copy link
Contributor

@jon-wei jon-wei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after CI

@jihoonson jihoonson merged commit 6aec8f0 into apache:master Mar 23, 2021
@clintropolis clintropolis added this to the 0.22.0 milestone Aug 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants