Fix link to defaultMetricDimensions.json#11156
Merged
asdf2014 merged 2 commits intoapache:masterfrom Apr 24, 2021
jp707049:master
Merged
Fix link to defaultMetricDimensions.json#11156asdf2014 merged 2 commits intoapache:masterfrom jp707049:master
defaultMetricDimensions.json#11156asdf2014 merged 2 commits intoapache:masterfrom
jp707049:master
Conversation
Fix `defaultMetricDimensions.json` path link
Contributor
Author
|
This is my first PR. Let me know if there is any other steps I need to follow. Thank you :) |
clintropolis
approved these changes
Apr 24, 2021
Member
clintropolis
left a comment
clintropolis
left a comment
There was a problem hiding this comment.
lgtm 👍, thanks for the fix!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the link to get
defaultMetricDimensions.jsonindropwizard-emitterdocs.This PR has: