Update check-licenses.py to open files with an explicit encoding#11269
Merged
jihoonson merged 1 commit intoapache:masterfrom May 19, 2021
Merged
Update check-licenses.py to open files with an explicit encoding#11269jihoonson merged 1 commit intoapache:masterfrom
jihoonson merged 1 commit intoapache:masterfrom
Conversation
mprashanthsagar
changed the title
jihoonson
added
the
Area - Dev
jihoonson
approved these changes
May 18, 2021
Contributor
jihoonson
left a comment
jihoonson
left a comment
There was a problem hiding this comment.
LGTM. Thanks @mprashanthsagar for your contribution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
check-licensesfails sometimes withUnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position 8090: ordinal not in range(128)Similar to PR #9462