Skip to content

Web console: Fix maxRowsPerSegment validation in hashed compaction spec#11308

Merged
clintropolis merged 6 commits intoapache:masterfrom
implydata:fix_compaction_hashed
May 27, 2021
Merged

Web console: Fix maxRowsPerSegment validation in hashed compaction spec#11308
clintropolis merged 6 commits intoapache:masterfrom
implydata:fix_compaction_hashed

Conversation

@vogievetsky
Copy link
Contributor

Fixes an issue where a compaction spec, reflected back from Druid, with hashed partitioning will not validate in the compaction dialog. This is due to the fact that maxRowsPerSegment was renamed to targetRowsPerSegment but when Druid sends back the compaction config with targetRowsPerSegment becomes maxRowsPerSegment. As a result maxRowsPerSegment is not fully deprecated and must still be surfaced in the form for correct validation.

In addition to the above this PR also makes the following fixes:

  • It is now possible to add a hidden field to the AutoForm. This means it can be validated correctly but will not surface in the form. This is needed for when targetRowsPerSegment will fully replace maxRowsPerSegment as we will still need to declare maxRowsPerSegment (as hidden) for the validation to work well with old configs that still use maxRowsPerSegment.
  • The Submit button will now be disabled if there is an erroneous JSON state in JSON inputs. Preventing the user from being able to paste an invalid JSON and hit submit (submitting the default config).
  • Date serialization was fixed in CSV/TSV download

This PR has:

  • been self-reviewed.
  • been tested in a test Druid cluster.

@suneet-s
Copy link
Contributor

@vogievetsky it looks like the web-console-e2e-tests are failing. If you need to push another patch to fix this PR, can you merge master into your branch. #11283 was merged earlier today, so it should make travis run a lot faster for these web-console only changes 😄 🥳

@vogievetsky
Copy link
Contributor Author

Happy days! Thank you for the tip @suneet-s and thank you for the work @clintropolis 🔥

@clintropolis clintropolis merged commit 31c811d into apache:master May 27, 2021
@vogievetsky vogievetsky deleted the fix_compaction_hashed branch May 27, 2021 23:38
@clintropolis clintropolis added this to the 0.22.0 milestone Aug 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants