Web console: Fix maxRowsPerSegment validation in hashed compaction spec#11308
Merged
clintropolis merged 6 commits intoapache:masterfrom May 27, 2021
Merged
Web console: Fix maxRowsPerSegment validation in hashed compaction spec#11308clintropolis merged 6 commits intoapache:masterfrom
clintropolis merged 6 commits intoapache:masterfrom
Conversation
Contributor
|
@vogievetsky it looks like the web-console-e2e-tests are failing. If you need to push another patch to fix this PR, can you merge master into your branch. #11283 was merged earlier today, so it should make travis run a lot faster for these web-console only changes 😄 🥳 |
Contributor
Author
|
Happy days! Thank you for the tip @suneet-s and thank you for the work @clintropolis 🔥 |
maytasm
approved these changes
May 27, 2021
clintropolis
approved these changes
May 27, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an issue where a compaction spec, reflected back from Druid, with hashed partitioning will not validate in the compaction dialog. This is due to the fact that
maxRowsPerSegmentwas renamed totargetRowsPerSegmentbut when Druid sends back the compaction config withtargetRowsPerSegmentbecomesmaxRowsPerSegment. As a resultmaxRowsPerSegmentis not fully deprecated and must still be surfaced in the form for correct validation.In addition to the above this PR also makes the following fixes:
targetRowsPerSegmentwill fully replacemaxRowsPerSegmentas we will still need to declaremaxRowsPerSegment(as hidden) for the validation to work well with old configs that still usemaxRowsPerSegment.Submitbutton will now be disabled if there is an erroneous JSON state in JSON inputs. Preventing the user from being able to paste an invalid JSON and hit submit (submitting the default config).Dateserialization was fixed in CSV/TSV downloadThis PR has: