mapping exception stacktrace logging#11325
Closed
egor-ryashin wants to merge 3 commits intoapache:masterfrom
Closed
mapping exception stacktrace logging#11325egor-ryashin wants to merge 3 commits intoapache:masterfrom
egor-ryashin wants to merge 3 commits intoapache:masterfrom
Conversation
Contributor
Author
|
Build failure is not relative to the changes: |
|
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this pull request should instead be reviewed, please simply write any comment. Even if closed, you can still revive the PR at any time or discuss it on the dev@druid.apache.org list. Thank you for your contributions. |
|
This pull request/issue has been closed due to lack of activity. If you think that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When you try a new Druid API or new parameters, the error message can lack details and one has to start a debugging session to find a line that produces an exception. For example, this message doesn't say what parameter produced NullPointerException (line 15 here doesn't say where the error happened in source code):
This logging writes a stacktrace to the logfile, it can be conveniently set up in configuration to log in production or not, besides the logging can be dynamically altered using JMX console too.
I've also added error logging to InputSourceSampler.
This PR has: