fix time_floor expression performance issue when origin is null#11380
Closed
kaijianding wants to merge 3 commits intoapache:masterfrom
Closed
fix time_floor expression performance issue when origin is null#11380kaijianding wants to merge 3 commits intoapache:masterfrom
kaijianding wants to merge 3 commits intoapache:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I noticed that
timestamp_floor("__time",'P1D',null,'Asia/Shanghai')is extremely slower(more than 3x in my case) thantimestamp_floor("__time",'P1D','','Asia/Shanghai')when I test this sqlThis is due to
in
TimestampFloorExprMacro.javaThe "null" expr doesn't match
Expr::isLiteral(), then TimestampFloorDynamicExpr is used, andTimestampFloorDynamicExpr.eval()create PeriodGranularity every time not like that only one time inTimestampFloorExpr's constructor.This patch modifies the translation to
timestamp_floor("__time",'P1D','','Asia/Shanghai')rather thantimestamp_floor("__time",'P1D',null,'Asia/Shanghai')Key changed/added classes in this PR
TimeFloorOperatorConversionDruidExpressionThis PR has: